Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't special case EOS paths #602

Merged
merged 1 commit into from
Feb 17, 2025
Merged

fix: Don't special case EOS paths #602

merged 1 commit into from
Feb 17, 2025

Conversation

olantwin
Copy link
Contributor

Fixes #566

@olantwin olantwin requested a review from a team as a code owner February 11, 2025 13:02
fairlyons
fairlyons approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@fairlyons fairlyons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried the normal test on lxplus: runsimscript -> shipreco -> shipana and had no problems.

@olantwin
Copy link
Contributor Author

I tried the normal test on lxplus: runsimscript -> shipreco -> shipana and had no problems.

Thanks for the quick feedback, it's highly appreciated!

@olantwin
Copy link
Contributor Author

Copying my comment from mattermost here for posterity:

This has the potential to be breaking for users who depend on the special casing on systems that don't have EOS mounted via FUSE. If you specify the full paths or work on lxplus where the FUSE mount exist, nothing should change.
This will be merged in a few days, if nobody makes any objections known to me.

Posted Monday, so probably "in a few days" = Friday or Monday.

@olantwin olantwin merged commit 0f0626c into master Feb 17, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fairlyons fairlyons fairlyons approved these changes

@antonioiuliano2 antonioiuliano2 Awaiting requested review from antonioiuliano2

@anupama-reghunath anupama-reghunath Awaiting requested review from anupama-reghunath

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove manual redirection to XROOTD for files on EOS
2 participants
@olantwin @fairlyons