-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build FairShip with the separated libTPythia6.so library #597
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also use find_package to specify TPythia6 as a dependency and use it to define include paths etc.
Builds fine on SLC9 |
@antonioiuliano2 Any updates on this? |
It would be good to add a changelog entry. While nothing user-facing should change, this is quite a major under-the-hood change. |
One thing we could try for backwards compatibility is to check whether ROOT has TPythia6, and if not search for the TPythia6 standalone package using find_package. |
I think once we confirm that this build fine with:
And does not build with:
We can probably merge this first version. A changelog entry would still be appreciated ;) |
@antonioiuliano2 Have you tried generating some muon DIS events with this branch? |
Yes, I did a test with the muonShieldOptimization/makeMuonDIS.py script and the default muConcrete.root file. Nothing out of the order to report.
Added an entry to the CHANGELOG. |
Ok, could you please rebase? |
ecaac25
to
e692a25
Compare
5a3920e
to
ff6e7d3
Compare
ff6e7d3
to
53b0a4e
Compare
Dear all,
This pull request is related to the update for ROOT 6.32 without TPythia6 support:
ShipSoft/shipdist#102.
Basically, this pull request will tell FairShip to load the TPythia6 from the shared library, now separated from ROOT.
It is used by
Best Regards,
Antonio