Review of the dimension of the cave #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d ECN3. 2) Added a Step in ECN3. 3) Removed the coat of the absorber. 4) Modified the dimension of the HA and absorber.
|
Could you please add a line to the changelog, and the renders/diagrams? Apart from that, this looks ready to be merged. |
|
Hi,
I updated my commit in github.
If something has to be included please let me know.
I would like to upload the presentation also in indico in order to link the
commit directly to the indico meeting page.
Thanks for your support.
See you soon,
Guglielmo
Il giorno lun 27 gen 2025 alle ore 11:10 Oliver Lantwin <
***@***.***> ha scritto:
… Could you please add a line to the changelog, and the renders/diagrams?
Apart from that, this looks ready to be merged.
—
Reply to this email directly, view it on GitHub
<#592 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMUZUEPEJCFNTJ46CHME5HL2MYAZRAVCNFSM6AAAAABV5UXXJGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJVGMZTCMZTGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Thanks for adding the diagrams. I don't see any changes to the commit, did you push them? |
|
@Gfrisella Could you please add a changelog message? Then this is ready to be merged. |
olantwin
reviewed
Jan 30, 2025
olantwin
approved these changes
Jan 30, 2025
This was referenced Feb 10, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review of the dimension of the cave: 1) Uptated dimensions of TCC8 and ECN3. 2) Added a Step in ECN3. 3) Removed the coat of the absorber. 4) Modified the dimension of the HA and absorber.
Link to the presentation: https://docs.google.com/presentation/d/1nRv-70tWRiKnH0pJtc1-iokxBEzhVT5Ow-1VYbAtBOk/edit#slide=id.g2d84c95faf5_2_0