Skip to content

Commit

Permalink
Merge pull request #61 from ServiceNow/fix-catalog-check
Browse files Browse the repository at this point in the history
Remove unnecessary URL validation in OrderHardwareTask
  • Loading branch information
jardinetsouffleton authored Jan 21, 2025
2 parents 8b9bb5b + dbb787c commit 29f275e
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions src/browsergym/workarena/tasks/service_catalog.py
Original file line number Diff line number Diff line change
Expand Up @@ -472,16 +472,6 @@ def teardown(self) -> None:
)

def validate(self, page: Page, chat_messages: list[str]) -> tuple[int, bool, str, dict]:
right_url = check_url_suffix_match(page, expected_url=self.final_url, task=self)
if not right_url:
return (
0,
False,
"",
{
"message": f"The page is not in the right URL to validate task {self.__class__.__name__}."
},
)

# Retrieve the request sysid from the URL
current_url = parse.urlparse(parse.unquote(page.evaluate("() => window.location.href")))
Expand Down

0 comments on commit 29f275e

Please sign in to comment.