Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filter map #901

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

krabina
Copy link
Contributor

@krabina krabina commented Jan 24, 2025

this updates the leaflet libraries needed for the filtered maps. Fixes #886

@krabina
Copy link
Contributor Author

krabina commented Feb 27, 2025

any idea why this is failing; @paladox @thomas-topway-it ?

@gesinn-it-gea
Copy link
Member

maybe it's not taking the latest base image with https://github.com/gesinn-it/docker-mediawiki/blob/main/Dockerfile#L37

@thomas-topway-it
Copy link
Contributor

it fails here

ERROR: process "/bin/sh -c if [ ! -z \"${SMW_VERSION}\" ]; then         composer-require.sh mediawiki/semantic-media-wiki ${SMW_VERSION} &&         echo 'wfLoadExtension( \"SemanticMediaWiki\" );\\n'              'enableSemantics( $wgServer );\\n'              >> __setup_extension__;     fi" did not complete successfully: exit code: 1

but I do not understand or know the reason

@thomas-topway-it
Copy link
Contributor

I'm not sure, but it may install SMW if the variable SMW_VERSION is not empty, however it could be defined as dev-master

@gesinn-it-gea
Copy link
Member

gesinn-it-gea commented Feb 27, 2025

It fails earlier: https://github.com/SemanticMediaWiki/SemanticResultFormats/actions/runs/12951327368/job/36126128026?pr=901#step:5:194

#8 0.380   [Composer\Plugin\PluginBlockedException]                                                                                                                                                
#8 0.380   wikimedia/composer-merge-plugin contains a Composer plugin which is blocked by your allow-plugins config. You may add it to the list if you consider it safe.                           
#8 0.380   You can run "composer config --no-plugins allow-plugins.wikimedia/composer-merge-plugin [true|false]" to enable it (true) or disable it explicitly and suppress this exception (false)  
#8 0.380   See https://getcomposer.org/allow-plugins        

Please rebase and try again

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.45%. Comparing base (5aa667b) to head (2c8f94a).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #901   +/-   ##
=========================================
  Coverage     45.45%   45.45%           
  Complexity     2319     2319           
=========================================
  Files            80       80           
  Lines          9051     9051           
=========================================
  Hits           4114     4114           
  Misses         4937     4937           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krabina krabina added this to the 5.0.0 milestone Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filtered format: leaflet-providers need updating
3 participants