Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #852 [jqplotchart] Internal error: Class "ResourceLoader" not f… #855

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

JLTRY
Copy link
Contributor

@JLTRY JLTRY commented Oct 29, 2024

Fixes #852 by adding use

@JeroenDeDauw
Copy link
Member

What MediaWiki version was MediaWiki\ResourceLoader\ResourceLoader added in?

@jaideraf
Copy link
Member

jaideraf commented Oct 29, 2024

Use statements are not alphabetically sorted

@JLTRY please sort the use statements

@JeroenDeDauw
Copy link
Member

What MediaWiki version was MediaWiki\ResourceLoader\ResourceLoader added in?

I confirmed it is in MW 1.39. This extension still supports MW 1.35 on master, but I think it's high time to drop that, so no issue with merging the PR as is.

@JLTRY please sort the use statements

It's cool you are paying attention, but I disagree that sorting imports is important. They are hidden by modern tools by default and can easily be auto sorted. Amending a PR to fix a sort does not seem like a good use of someones time.

JLTRY added 2 commits October 29, 2024 20:32
@jaideraf
Copy link
Member

jaideraf commented Oct 30, 2024

Thank you @JLTRY, it is all fine now: all the tests pass. Your contributions are welcome. 😊

@JeroenDeDauw JeroenDeDauw merged commit 1c518d8 into SemanticMediaWiki:master Oct 31, 2024
2 checks passed
@jongfeli
Copy link

Thanks for the fix. I just tested SemanticResultFormats master and the datatables format is fixed, it works but the jqplot format still gives Error: Class "ResourceLoader" not found I am happy to do some tests or send info if needed, so please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[jqplotchart] Internal error: Class "ResourceLoader" not found
4 participants