fix precomputed regridder save bug #462
Conversation
There was a problem hiding this comment.
@stephenworsley This looks ideal 👍
The only thing I'd ask you to consider is pushing the defensive esmf_version logic up into the regridder instance, such that it defaults to a known "unknown" string value (defined by a suitable module constant e.g., ESMF_VERSION_DEFAULT: str = "unknown".
You can then control setting the esmf_version to an actual esmf version or nullify it for appropriate operations (like the user providing pre-computed weights). But in essence, it's always a string and never None.
So esmf_version will always be a string, thus loading/saving should always "just work"™️.
Perhaps also consider (not necessarily in this PR) what matadata on a regridder is read-only or mutable. I'd guess that esmf_version is read-only 🤔
Anyways, have a ponder and I'm happy to go with whatever you recommend 💯
|
pre-commit.ci autofix |
Addresses #433.