Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deim docstring to include types and default values of kwargs #33

Merged
merged 1 commit into from
Oct 15, 2022
Merged

Update deim docstring to include types and default values of kwargs #33

merged 1 commit into from
Oct 15, 2022

Conversation

bowenszhu
Copy link
Member

TYPEDSIGNATURES from DocStringExtensions.jl doesn't show the types and default values of keyword arguments (JuliaDocs/DocStringExtensions.jl#97 and JuliaDocs/DocStringExtensions.jl#107).
But they are important for one of the methods of deim.

This PR thus changes
image
to
image

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #33 (8d3d63a) into main (c3ed12e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   92.96%   92.96%           
=======================================
  Files           5        5           
  Lines         199      199           
=======================================
  Hits          185      185           
  Misses         14       14           
Impacted Files Coverage Δ
src/deim.jl 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas ChrisRackauckas merged commit a5040d2 into SciML:main Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants