Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring background ingestor. #40

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Refactoring background ingestor. #40

merged 5 commits into from
Jul 5, 2024

Conversation

YooSunYoung
Copy link
Contributor

  • Renamed the background ingestor script so that it can be used as a module as well.
  • Extracted the system helper function (exiting at exceptions) to a separate helper module
    • The scripts can be more concentrating on the logic.
    • Avoid duplicating code
  • Add how to install/run in the readme both, online/background ingestor.

Next step will be adding functionalities into the background ingestor and add tests.

@YooSunYoung YooSunYoung requested a review from nitrosx July 5, 2024 07:40
@nitrosx
Merge pull request #41 from SciCatProject/background-ingester-config
2e4c889 
Background ingestor configuration refactoring.
@YooSunYoung YooSunYoung merged commit 317ec57 into main Jul 5, 2024
3 checks passed
@YooSunYoung YooSunYoung deleted the system-helper branch July 5, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrosx nitrosx nitrosx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YooSunYoung @nitrosx