Graylog integration #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing flake8 linting
fixing linting
fixing linting issues
|
This PR contains changes from multiple branches. Can you change the target branch so that the diff is clean? Or point out which files are specifically about the graylog integration and which other PRs need to be merged first? |
|
I also added graylog into the integration test docker services: #34 |
YooSunYoung
reviewed
Jun 11, 2024
resources/config.sample.json
Outdated
Comment on lines
41
to
44
| "graylog_log" : false, | ||
| "graylog_host" : "", | ||
| "graylog_port" : "", | ||
| "graylog_facility" : "scicat.ingestor" |
There was a problem hiding this comment.
@nitrosx Can it be wrapped into a different group ...? Since it's an external service we are using.
YooSunYoung
reviewed
Jun 11, 2024
Graylog integration - configuration refactoring
YooSunYoung
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the option to send the logs to a graylog server defined in configuration