Removing deprecated OFI_USE_PROVIDER env variable #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidozog
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
I'm good with this change.
I'm also dubious there are valid use-cases for SHMEM_OFI_PROVIDER (when FI_PROVIDER could/should be preferred), but I suppose we should keep it around in case there are more complicated scenarios alongside other runtimes... See for example ofiwg/libfabric#8079. Takeaway: SOS itself does not set FI_PROVIDER, and it shouldn't going forward. But users can set FI_PROVIDER if desired... it filters the available providers in libfabric at init.
It might be good to document somewhere that SHMEM_OFI_PROVIDER sets prov_name in the libfabric Fabric Attributes structure (see fi_fabric.3), nothing more.
markbrown314
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.