-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage Service Enhancements and Refactoring #350
Open
Ziadsharkos
wants to merge
21
commits into
main
Choose a base branch
from
hotfix/no-ref/change-download-url
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation and error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Overview
This PR introduces significant improvements to the Storage Service, including enhancements to file handling, API documentation, security configurations, and dependency management. These changes optimize file storage and retrieval while ensuring better maintainability and test coverage.
✨ Key Changes
🚀 Feature Enhancements
🔄 Refactoring and Code Improvements
ObjectStorageService
to encapsulate business logic in thestorage
package.MinioConfig
service to include bucket existence checks and structured Minio client initialization.🛠 Fixes and Security Updates
/objects/file/**
for file retrieval.SecurityConfig
andMinioConfig
.@Generated
annotation toMinioConfig
andSecurityConfig
to improve code maintainability.📦 Dependency and Build Optimizations
WebMVC
andMimeUtil
to handle file operations efficiently.🧪 Testing and Coverage
📌 Breaking Changes
ObjectResponse
DTO and replaced it withObjectStorageResponse
.🚀 How to Test
/objects/upload
./objects/file/{path}
../gradlew test