-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Corrected ObjectToCamel, ObjectToPascal, ObjectToSnake types #81
base: main
Are you sure you want to change the base?
Conversation
Frankly, seeing fixes like this hang for months is discouraging when the library is as popular as it is. |
@BigBallard If you want to re-write the PR so it doesn't reformat all the lines then I will look at it. |
@ryanhaugh If you can preserve existing formatting then I can look at these changes. |
@RossWilliams apologies for all the formatting changes - I've fixed them. |
This PR also fixes this issue: ObjectToCamel<{
property_name: undefined;
}>; incorrectly returns: {
propertyName: unknown[];
} when it should return: {
propertyName: undefined;
} @RossWilliams let me know if you need anything else from me so we can get this across the line - thanks! |
@ryanhaugh Build fails, you need to adjust the tests. |
@RossWilliams I've simplified |
@RossWilliams any chance you could take another look at this PR? |
@RossWilliams anything I can do to help move this along? |
Starting to think this won't be reviewed - please prove me wrong. |
There is an issue with the
ObjectToCamel
,ObjectToPascal
,ObjectToSnake
where they don't handle an array of string number unions correctly.For example, the following:
incorrectly returns:
when it should return:
This PR fixes
ObjectToCamel
,ObjectToPascal
,ObjectToSnake
to return the correct string/number union array type.