Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook array.Changed to update list proxies when the array changes from an external source #2

Merged
merged 2 commits into from
Nov 23, 2024

Conversation

Nytra
Copy link
Collaborator

@Nytra Nytra commented Nov 23, 2024

This works, except for ParticleBursts for some reason

Fixes #1

@Nytra Nytra requested a review from Banane9 November 23, 2024 20:46
@Banane9
Copy link
Member

Banane9 commented Nov 23, 2024

As in, just outside updates don't work on the particle burst, or they don't work in general?

I suppose it's not super important anyways, with PhotonDust coming out soon.

@Banane9 Banane9 merged commit ad69416 into master Nov 23, 2024
2 checks passed
@Banane9 Banane9 deleted the nytra/arrayChanged branch November 23, 2024 21:39
@Nytra
Copy link
Collaborator Author

Nytra commented Nov 23, 2024

Just the outside updates. They will add the correct number of elements in the list but don't set the values.

@Banane9
Copy link
Member

Banane9 commented Nov 23, 2024

Weiiiird... Oh well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If the array is changed outside of the mod, our proxy lists are not updated to reflect it
2 participants