Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#12 issue solved - Changes done in the UI of home page better user Interaction. #170

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

SoumyaU25
Copy link
Contributor

@SoumyaU25 SoumyaU25 commented Oct 16, 2024

πŸ“‹ Description

πŸ”¨ Changes Made

βœ… Checklist

Before submitting the PR, please make sure you have completed the following:

  • I have followed all the guidlines mentioned in CONTRIBUTING.md.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (if applicable).
  • I have tested it locally and it works fine.
  • Any dependent changes have been merged and published in downstream modules.

🏷️ Types of Changes

What type of changes does your code introduce? (Check all that apply)

  • Bug fix (non-breaking change which fixes an issue) πŸ›

  • New feature (non-breaking change which adds functionality) ✨

  • UI enhancement (non-breaking change which enhances UI) 🎨

  • Documentation update πŸ“š

  • Fixes #

πŸ“Έ Screenshots (if applicable)

r1 r3 r4

Thank you for contributing to Research Nexus! We look forward to reviewing your PR and getting it merged!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸŽ‰ Thank you @SoumyaU25 for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

Copy link
Member

@Harshdev098 Harshdev098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is something wrong with this,
image

Please increase the font-size of the navbar lists and the minimize the padding and side margin

@SoumyaU25
Copy link
Contributor Author

Okay @Harshdev098 I'll do that

@SoumyaU25
Copy link
Contributor Author

SoumyaU25 commented Oct 17, 2024

Hello @Harshdev098 I have done the changes , I have added a Search bar also. Please Check it out.

@Harshdev098
Copy link
Member

Are the background image that you have set in the screenshot is not working

image

@SoumyaU25
Copy link
Contributor Author

@Harshdev098 actually it's working fine at my end, I have set the right path for it.
r5

.banner {
width: 100%;
height: 100vh;
background-image: linear-gradient(rgba(8, 23, 82, 0.75), rgba(30, 2, 30, 0.75)), url('public/images/calm.jpg');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit the url with this ../images/calm.jpg

<div class="nav">
<img class="logo" src="images/logo.png" alt="">
<form class="search-bar">
<input type="text" placeholder="Search...">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increase the input size of search box something like 20vw

<li><a href="">About</a></li>
<li><a href="">Add Topic</a></li>
<li onmouseover="show()" onmouseout="hide()"><a href=""
title="View Notifications"><i id="firsticon" class="fa-sharp fa-regular fa-bell"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notification btn is not working as expected onmouseover and onmouseout properties

@SoumyaU25
Copy link
Contributor Author

SoumyaU25 commented Oct 17, 2024

@Harshdev098 I have done all the changes as you said
changed the path for background image
the input size of search box is increased about 22vw.
The notification btn is working fine now.
r6

@Harshdev098
Copy link
Member

@SoumyaU25 Delete the .vscode folder

@SoumyaU25
Copy link
Contributor Author

Okay @Harshdev098

@SoumyaU25
Copy link
Contributor Author

Done @Harshdev098

@Harshdev098 Harshdev098 merged commit 24c1d7c into Research-Nexas:main Oct 17, 2024
1 check passed
@Harshdev098
Copy link
Member

Harshdev098 commented Oct 17, 2024

@SoumyaU25 Can you update your PR description referencing the issue number you have fixed
I have to add labels

@Harshdev098 Harshdev098 added hacktoberfest This issue belongs to hacktoberfest gssoc-ext This issue is under GSSoc Ext program level2 level2 lebel for gssoc level hacktoberfest-accepted label for accepted PRs under hacktoberfest labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext This issue is under GSSoc Ext program hacktoberfest This issue belongs to hacktoberfest hacktoberfest-accepted label for accepted PRs under hacktoberfest level2 level2 lebel for gssoc level
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants