Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stakeholders_Password_requirements #115

Closed

Conversation

smog-root
Copy link
Contributor

@smog-root smog-root commented Oct 14, 2024

Issue: #113
Sorry. i have made the PR fast and didn't see you'r comment on the issue #113

i made changes to Stakeholders signup page!

stk_signup.html:

stk_signup.html

can you please add gssoc-ext with level2 and a hacktober-accepted label to this?

if you add level3 to this it's really great for me! (it's a request!)

Copy link
Contributor

@Ajay-singh1 Ajay-singh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!Approved.

@smog-root
Copy link
Contributor Author

Add gssoc-ext with level3 and hacktoberfest-accepted labels!

Copy link
Member

@Harshdev098 Harshdev098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few changes required in this PR-

  • Make another PR with different branch, its likely you have made two PRs with same branches its showing the changes of PR Password_Minimum_Requirement_For_Signup #114
  • The registration process is not working properly it seems there is some error causing it, not to request the node server
    it can't handle the registration process

image

  • Also include the validateForm function logic in the register function

I am closing it for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants