Skip to content

Commit

Permalink
Add Python 3.13 for PR checks in GHA
Browse files Browse the repository at this point in the history
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
  • Loading branch information
Gauravtalreja1 committed Jan 27, 2025
1 parent ef28661 commit 3bef050
Show file tree
Hide file tree
Showing 8 changed files with 16 additions and 17 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python: [3.9, 3.12]
python: [3.11, 3.12, 3.13]
steps:
- name: Checkout WrapanAPI
uses: actions/checkout@v3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release_to_pypi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Set Up Python3
uses: actions/setup-python@v3
with:
python-version: 3.9
python-version: 3.13

- name: Install Dependencies
run: |
Expand Down Expand Up @@ -52,7 +52,7 @@ jobs:
- name: Set Up Python3
uses: actions/setup-python@v3
with:
python-version: 3.9
python-version: 3.13

- name: Setup and Build
run: |
Expand Down
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ ci:
repos:
- repo: https://github.com/astral-sh/ruff-pre-commit
# Ruff version.
rev: v0.8.3
rev: v0.9.3
hooks:
# Run the linter.
- id: ruff
Expand All @@ -24,7 +24,7 @@ repos:
- id: end-of-file-fixer
- id: debug-statements
- repo: https://github.com/asottile/pyupgrade
rev: v3.19.0
rev: v3.19.1
hooks:
- id: pyupgrade
args: [--py3-plus, --py311-plus]
6 changes: 3 additions & 3 deletions tests/test_hawkular.py
Original file line number Diff line number Diff line change
Expand Up @@ -291,9 +291,9 @@ def test_list_server_datasource(provider):
assert datasource.id
assert datasource.name
assert datasource.path
assert (
found | provider.inventory._stats_available["num_datasource"](provider.inventory) > 0
), "No any datasource is listed for any of feeds, but they exists"
assert found | provider.inventory._stats_available["num_datasource"](provider.inventory) > 0, (
"No any datasource is listed for any of feeds, but they exists"
)


def test_path(provider):
Expand Down
4 changes: 2 additions & 2 deletions wrapanapi/systems/container/rhopenshift.py
Original file line number Diff line number Diff line change
Expand Up @@ -1273,7 +1273,7 @@ def check_scale_value():

else:
raise ValueError(
"This name %s is not found among " "deployment configs or stateful sets", name
"This name %s is not found among deployment configs or stateful sets", name
)
self.logger.info("scaling entity %s to %s replicas", name, replicas)
wait_for(check_scale_value, timeout=wait, fail_condition=lambda val: val != replicas)
Expand Down Expand Up @@ -1432,7 +1432,7 @@ def is_vm_stopped(self, vm_name):
pods = self.k_api.list_namespaced_pod(namespace=vm_name).items
if pods:
self.logger.info(
("some pods are still " "running: {}").format([pod.metadata.name for pod in pods])
("some pods are still running: {}").format([pod.metadata.name for pod in pods])
)
return not bool(pods)

Expand Down
6 changes: 2 additions & 4 deletions wrapanapi/systems/msazure.py
Original file line number Diff line number Diff line change
Expand Up @@ -784,7 +784,7 @@ def list_security_group(self):
def list_security_group_ports(self, sec_group_name, resource_group=None):
resource_group = resource_group or self.resource_group
self.logger.info(
'Attempting to List ports from Azure security group "%s"' 'in resource group "%s"',
'Attempting to List ports from Azure security group "%s"in resource group "%s"',
sec_group_name,
resource_group,
)
Expand Down Expand Up @@ -974,9 +974,7 @@ def create_netsec_group_port_allow(
**kwargs,
):
resource_group = resource_group or self.resource_group
self.logger.info(
"Attempting to Create New Azure Security Group " "Rule '%s'.", secgroup_name
)
self.logger.info("Attempting to Create New Azure Security Group Rule '%s'.", secgroup_name)

parameters = NetworkSecurityGroup(location=self.region)
parameters.security_rules = [
Expand Down
2 changes: 1 addition & 1 deletion wrapanapi/systems/openstack.py
Original file line number Diff line number Diff line change
Expand Up @@ -772,7 +772,7 @@ def add_tenant(
if user and roles:
if self.keystone_version == 3:
raise NotImplementedError(
"Role assignments for users are not implemented yet for " "Keystone V3"
"Role assignments for users are not implemented yet for Keystone V3"
)
user = self._get_user(name=user)
for role in roles:
Expand Down
5 changes: 3 additions & 2 deletions wrapanapi/systems/rhevm.py
Original file line number Diff line number Diff line change
Expand Up @@ -1240,8 +1240,9 @@ def change_storage_domain_state(self, state, storage_domain_name, timeout=300):
active = types.StorageDomainStatus.ACTIVE
if desired_state is None:
raise ValueError(
"Invalid state [{}] passed for setting storage domain, "
"value values are {}".format(state, list(types.StorageDomainStatus))
"Invalid state [{}] passed for setting storage domain, value values are {}".format(
state, list(types.StorageDomainStatus)
)
)
for datacenter in self._data_centers_service.list():
for domain in self.api.follow_link(datacenter.storage_domains):
Expand Down

0 comments on commit 3bef050

Please sign in to comment.