This repository has been archived by the owner on Feb 12, 2025. It is now read-only.
Add component for removing portfolio items #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgalis
changed the title
|
This pull request is not mergeable. Please rebase and repush. |
hstastna
force-pushed
the
Remove_portfolio_items_component
branch
from
600dcf7 to
2aef684
Compare
hstastna
force-pushed
the
Remove_portfolio_items_component
branch
5 times, most recently
from
3cbe34d to
2f28f4c
Compare
hstastna
force-pushed
the
Remove_portfolio_items_component
branch
3 times, most recently
from
d458c07 to
397ca35
Compare
lgalis
reviewed
Dec 6, 2018
hstastna
force-pushed
the
Remove_portfolio_items_component
branch
5 times, most recently
from
f7ce79d to
6eba6c5
Compare
hstastna
changed the title
|
This pull request is not mergeable. Please rebase and repush. |
hstastna
force-pushed
the
Remove_portfolio_items_component
branch
from
6eba6c5 to
29050ba
Compare
Hyperkid123
reviewed
Jan 21, 2019
hstastna
force-pushed
the
Remove_portfolio_items_component
branch
9 times, most recently
from
beaafef to
075877a
Compare
Add the component also with Cancel, Remove buttons.
hstastna
force-pushed
the
Remove_portfolio_items_component
branch
from
075877a to
b874525
Compare
hstastna
force-pushed
the
Remove_portfolio_items_component
branch
5 times, most recently
from
4c3a391 to
e6e5293
Compare
Hyperkid123
reviewed
Jan 22, 2019
| isKebabOpen: false, | ||
| isOpen: false, | ||
| filteredItems: [], | ||
| selectItems: [] |
There was a problem hiding this comment.
type: should be probably selectedItems
Hyperkid123
reviewed
Jan 22, 2019
| <PortfolioItem | ||
| key={ item.id } | ||
| { ...item } | ||
| { ...{ |
There was a problem hiding this comment.
No need for the double object destructing, just assign them as regular props:
isSelectable={ this.props.location.pathname.includes('/remove-products') }
...
added 5 commits
January 22, 2019 14:21
Add removePortfolioItem and removePortfolioItems functions, fix some small lint errors.
hstastna
force-pushed
the
Remove_portfolio_items_component
branch
from
e6e5293 to
20e7a01
Compare
|
Checked commits hstastna/service_portal-ui@22827ca~...20e7a01 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Hyperkid123
approved these changes
Jan 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Add the component and another smaller changes (syntax, styling, removing button for editing portfolios from navigation, etc).
Screenshots:
Remove products button for removing portfolio items from the portfolio:
Selecting and then removing product from the portfolio:
After removing selected product from the portfolio: