Change clang-offload-bundler to 4-tuple #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKKnorr
suggested changes
Jan 27, 2025
There was a problem hiding this comment.
Thanks for the contribution!
This does however also affect the assembly_to_executable example, and also requires these changes to be added to the corresponding CMakeList.txt and Makefile. Otherwise the documentation says something different than the example does
Thanks for the review, I have made the requested changes. |
MKKnorr
approved these changes
Jan 29, 2025
shiltian
reviewed
Jan 29, 2025
| @@ -68,7 +68,7 @@ main_device.o: hip_obj_gen.mcin offload_bundle.hipfb | |||
|
|
|||
| offload_bundle.hipfb: $(GPU_ARCHS:%=main_%.o) | |||
| $(CLANG_OFFLOAD_BUNDLER) -type=o -bundle-align=4096 \ | |||
| -targets=host-x86_64-unknown-linux,$(GPU_ARCH_TRIPLES) \ | |||
| -targets=host-x86_64-unknown-linux-gnu,$(GPU_ARCH_TRIPLES) \ | |||
There was a problem hiding this comment.
Another needs to be noted is the GPU_ARCH_TRIPLES.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change clang-offload-bundler to 4-tuple in the documentation. This PR aims to address: #186.