Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcxproj][#166][Windows][fix] Fix monte_carlo_pi project files #167

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

emankov
Copy link
Collaborator

@emankov emankov commented Sep 25, 2024

  • [IMP] The vcxproj files are fixed to be used with HIP SDK 6.1 because all other projects have not been switched to 6.2 yet.
  • [ToDo] Switch all the projects to HIP SDK 6.2.

@emankov emankov added fix VS2022 Visual Studio 2022-related only VS2019 Visual Studio 2019-related only VS2017 Visual Studio 2022-related only 6.1 ROCm HIP 6.1-related labels Sep 25, 2024
@emankov emankov requested a review from kzhuravl September 25, 2024 16:35
@emankov emankov self-assigned this Sep 25, 2024
@emankov emankov merged commit 427b754 into ROCm:develop Sep 25, 2024
5 checks passed
+ [IMP] The `vcxproj` files are fixed to be used with `HIP SDK 6.1` because all other projects have not been switched to 6.2 yet.
+ [ToDo] Switch all the projects to `HIP SDK 6.2`.
@emankov emankov requested a review from hhalilovAMD September 25, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.1 ROCm HIP 6.1-related fix VS2017 Visual Studio 2022-related only VS2019 Visual Studio 2019-related only VS2022 Visual Studio 2022-related only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant