[RAJAPerf] updated build/run script #1154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated script to use the latest version of RAJAPerf. It contains a bug fix for the build error we currently observe. Another bug ticket is still open (LLNL/RAJAPerf#493). !!! Requires cmake version 3.23 !!!!
ThorBl
requested review from
estewart08,
gregrodgers and
ronlieb
as code owners
|
The latest version of RAJAPerf requires CMake v3.23? |
|
A dependency (RAJA) requires CMake v3.23. |
|
I plan on updating our cmake to 3.25.2 for the next release to support Ubuntu 24.04. |
|
Since, AOMP is shipped with CMake 3.25.2 now, this patch is ready to land. |
|
Does AOMP auto-update the CMake that is installed or do people need to do that manually? |
I think build_aomp.sh downloads, installs, and sets path to the right cmake version if it doesn't find it in the system. |
jplehr
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the script to build the latest version of RAJAPerf. It contains a bug fix for the build error we are currently observing. Another bug ticket is still open (LLNL/RAJAPerf#493).
!!! Requires cmake version 3.23 !!!!