Skip to content

Commit

Permalink
resolve conflict
Browse files Browse the repository at this point in the history
  • Loading branch information
liligwu committed Oct 20, 2022
2 parents 24c1e82 + ad123f2 commit 87dcbf9
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions fbgemm_gpu/codegen/embedding_forward_split_template.cu
Original file line number Diff line number Diff line change
Expand Up @@ -526,9 +526,8 @@ Tensor {{ "dense" if dense else "split" }}_embedding{{ "_nobag" if nobag else ""
/*
* current limitations
1. sparse, and bag
2. embedding dims in [64, 128, 192, 256]
3. yet to support non-uniform table locations (all be on devs)
4. yet to support duplicate tables from some cases in exact optim (fbgemm_gpu/split_embedding_configs.py)
2. yet to support non-uniform table locations (all be on devs)
3. yet to support duplicate tables from some cases in exact optim (fbgemm_gpu/split_embedding_configs.py)
*/
{% if not nobag %}
{% if not dense %}
Expand Down

0 comments on commit 87dcbf9

Please sign in to comment.