Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine application output and ADRG updates #47

Merged
merged 12 commits into from
Oct 3, 2022
Merged

Conversation

rpodcast
Copy link
Member

@rpodcast rpodcast commented Oct 3, 2022

This PR contains the following updates in preparation for the first test transfer with FDA:

  • During a recent Shiny for Submissions task force meeting, I led a brief demonstration of the pilot application. Attendees from the FDA expressed concern about the display of p-values when applying the teal filters to input data. The application now obscures the display of p-values anytime the user applies a filter that reduces the data set. Additional footnotes to the affected tables (primary and efficacy) as well as an additional note in the application information page are now present in the application. Here is a small demo:

P-value visibility

The application has been re-deployed on Shinyapps.io: https://rconsortium.shinyapps.io/submissions-pilot2

  • The KM plot viewing window has been enlarged to 800 pixels, which greatly improves the legibility of the at-risk table metrics below the plot. I experimented with modifying the font size used for the at-risk table by digging into the internals of visR::add_risk_table, but for strange reasons the Shiny app will not render the changes. I will submit an issue to the {visR} repository with a reproducible example.
  • The ADRG has been updated with additional comments (thank you, @lengning & @fb-elong!) The only change I did not incorporate was the install = TRUE flag in the pkglite::unpack() call based on the following:
    • The goal is to have the pilot2wrappers package installed during the {renv} restoration process. If we include install = TRUE, that will circumvent the {renv} procedure and potentially install different versions of the dependency packages used to build the Shiny application.
    • The errors likely occurred due to an outdated package installer of {pilot2wrappers} within the renv/cellar directory, which was built with a DESCRIPTION file missing key dependencies (such as {teal.data}), as well as missing the key function set_data_path. After correcting these issues, I tested the procedure for installing and executing the application in a completely fresh Windows 11 virtual machine, and the application was un-packed and executed with no issues. I will also try on a fresh Mac OS X VM and RStudio Cloud for completeness.

@rpodcast rpodcast merged commit 6299dfe into main Oct 3, 2022
@elong0527
Copy link
Collaborator

Thanks a lot Eric!

@fb-elong
Copy link
Contributor

fb-elong commented Oct 3, 2022

Could you double check the comments in the attached cover letter and adrg file of the feedback below?

#46 (comment)

It seems some comments are still not resolved. (e.g. mismatch R version 4.1.2 vs. 4.2.0) , missing pkglite package etc)

@lengning
Copy link
Collaborator

lengning commented Oct 4, 2022

& bump pilot2wrappers version in adrg to 0.5.0? (section 7.4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants