Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScopeGuard improvements #651

Merged
merged 2 commits into from
Jan 30, 2024
Merged

ScopeGuard improvements #651

merged 2 commits into from
Jan 30, 2024

Conversation

ASpoonPlaysGames
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames commented Jan 27, 2024 •
edited by GeckoEidechse
Loading

std::function introduces a layer of indirection that can be removed through templating the class.

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Jan 27, 2024
@Jan200101
Copy link
Contributor

replaces the use of std::function with templates and a flag to check when we are done.
Code looks good, though this will result in multple versions of the class (which isn't a problem unless we are going ham with it)

@Jan200101 Jan200101 removed the needs code review Changes from PR still need to be reviewed in code label Jan 27, 2024
@GeckoEidechse GeckoEidechse added the almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge label Jan 29, 2024
GeckoEidechse
GeckoEidechse approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working (i.e. not breaking) in quick testing ^^

@GeckoEidechse GeckoEidechse removed needs testing Changes from the PR still need to be tested almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Jan 30, 2024
@GeckoEidechse GeckoEidechse merged commit 6ad955a into R2Northstar:main Jan 30, 2024
3 checks passed
@ASpoonPlaysGames ASpoonPlaysGames deleted the cleanup-scopeguard branch February 11, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ASpoonPlaysGames @Jan200101 @GeckoEidechse