Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: export mod related code to dedicated package #649

Closed
wants to merge 6 commits into from
Closed

refactor: export mod related code to dedicated package #649

wants to merge 6 commits into from

Conversation

Alystrasz
Copy link
Contributor

Export all mod-related code to dedicated package to make future modifications easier to review.
And having the Mod class inside the modmanager package seemed unappropriate.

@Alystrasz
Copy link
Contributor Author

Alystrasz commented Jan 22, 2024 •
edited
Loading

I didn't even open minizip config wtf

@GeckoEidechse GeckoEidechse added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code feedback wanted Feedback is wanted whether the changes by this PR are desired labels Feb 18, 2024
@Alystrasz
Copy link
Contributor Author

I didn't even open minizip config wtf

The build was failing due to a zlib external issue, see #650

@Alystrasz Alystrasz closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feedback wanted Feedback is wanted whether the changes by this PR are desired needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alystrasz @GeckoEidechse