Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port navmesh debug renderer from primedev #626

Merged
merged 28 commits into from
Feb 5, 2024
Merged

Port navmesh debug renderer from primedev #626

merged 28 commits into from
Feb 5, 2024

Conversation

ASpoonPlaysGames
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames commented Dec 22, 2023 •
edited by GeckoEidechse
Loading

Comes with a bunch of dependencies that I also ported

depends on

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Dec 22, 2023
@ASpoonPlaysGames ASpoonPlaysGames added the depends on another PR Blocked until the PR it depends on is merged label Dec 22, 2023
@ASpoonPlaysGames
Copy link
Contributor Author

image
I'm considering this tested

@ASpoonPlaysGames ASpoonPlaysGames removed the needs testing Changes from the PR still need to be tested label Dec 27, 2023
@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Dec 27, 2023
@ASpoonPlaysGames
Copy link
Contributor Author

To turn this on, do sv_cheats 1; enable_debug_overlays 1 and then navmesh_debug_hull 1 (or any value 1-4 iirc)

@GeckoEidechse GeckoEidechse removed the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Dec 27, 2023
@GeckoEidechse GeckoEidechse removed the depends on another PR Blocked until the PR it depends on is merged label Dec 27, 2023
GeckoEidechse
GeckoEidechse reviewed Dec 27, 2023
View reviewed changes
GeckoEidechse
GeckoEidechse reviewed Dec 27, 2023
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working testing on Forwardbase Kodai using the provided instructions.

@GeckoEidechse GeckoEidechse mentioned this pull request Dec 27, 2023
Closed
@GeckoEidechse GeckoEidechse added the almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge label Dec 27, 2023
@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Jan 3, 2024
@github-actions github-actions bot removed the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Jan 3, 2024
@itscynxx itscynxx mentioned this pull request Jan 9, 2024
Merged
uniboi
uniboi approved these changes Jan 21, 2024
View reviewed changes
Copy link
Contributor

@uniboi uniboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't really comment on the structs or mesh renders but the code looks pretty good. I'm going to steal the debug renders for my plugins lmao

@ASpoonPlaysGames ASpoonPlaysGames added READY TO MERGE This mergeable right now and removed needs code review Changes from PR still need to be reviewed in code almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Jan 25, 2024
@GeckoEidechse
Copy link
Member

Technically not fully through code (re stuff @uniboi mentioned on structs and mesh renderers) but I'm trusting @F1F7Y on the initial code and @ASpoonPlaysGames on the cherry-pick, so merging regardless ^^

@GeckoEidechse GeckoEidechse merged commit 73262ca into R2Northstar:main Feb 5, 2024
3 checks passed
@F1F7Y
Copy link
Member

F1F7Y commented Feb 5, 2024

Replying to @GeckoEidechse but don't want to ping others

The renderer itself is ported from recast and adapted for the debug overlay interface with some optimization ( range and plane based culling, outline duplicate culling ). I've tested it thoroughly in primedev.

@GeckoEidechse GeckoEidechse mentioned this pull request Feb 8, 2024
Open
@ASpoonPlaysGames ASpoonPlaysGames deleted the navmesh-renderer branch February 11, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeckoEidechse GeckoEidechse GeckoEidechse left review comments

@F1F7Y F1F7Y F1F7Y left review comments

@uniboi uniboi uniboi approved these changes

Assignees
No one assigned
Labels
READY TO MERGE This mergeable right now
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ASpoonPlaysGames @GeckoEidechse @F1F7Y @uniboi @RoyalBlue1