Update pixi lockfile #260
Merged
Update pixi lockfile #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![quant-ranger[bot]](https://avatars.githubusercontent.com/in/330907?s=60&v=4){kind=small}
quant-ranger
bot
added
the
dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
=======================================
Coverage 93.39% 93.39%
=======================================
Files 18 18
Lines 1998 1998
=======================================
Hits 1866 1866
Misses 132 132 ☔ View full report in Codecov by Sentry. |
|
Hi @SimonLangerQC ! :) Iirc you were most involved with the test that is currently failing. Would you mind providing your perspective on the tests which are currently failing? |
|
@kklein I just asked him what was the memory limit related mark which is the one that's failing the test for DB2. We could increase the limit from 60 to 75, but would be good to be reminded why there was the limit in the first place. |
kklein
reviewed
Feb 4, 2025
| @@ -54,7 +54,8 @@ test = "pytest tests/integration --backend=postgres" | |||
| coverage = "pytest tests/integration --cov=datajudge --cov-report=xml --cov-append --backend=postgres" | |||
|
|
|||
| [feature.db2.dependencies] | |||
| ibm_db = "*" | |||
| # Upper bounded due to https://github.com/ibmdb/python-ibmdb/issues/986 | |||
There was a problem hiding this comment.
@ivergara See this :)
Credits to Simon
ivergara
approved these changes
Feb 4, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit dependencies
docs on linux-64
{db2-sa1, default, mssql-sa1, mssql-sa2, mypy, postgres-sa1, postgres-sa2, sa1, sa2} on linux-64
db2-sa1 on win-64
Implicit dependencies
docs on linux-64
docs on win-64
{default, mssql-sa1, mssql-sa2, mypy, postgres-sa1, postgres-sa2, sa1, sa2} on linux-64
{default, mssql-sa1, mssql-sa2, mypy, postgres-sa1, postgres-sa2, sa1, sa2} on linux-64
{bigquery-py38, bigquery-sa1} on all platforms
docs on win-64
{bigquery-py38, bigquery-sa1, db2-py310, db2-py38, db2-py39, db2-sa1, default, impala-py38, impala-sa1, py310, py311, py312, py38, py39, sa1, sa2, snowflake-py38} on linux-64
db2-sa1 on {linux-64, win-64}
{db2-py310, db2-py38, db2-py39, db2-sa1} on all platforms
mypy on win-64
{db2-py39, mssql-py39, postgres-py39, py39} on {osx-arm64, win-64}
lint on win-64
{bigquery-sa1, db2-sa1, impala-sa1, mssql-sa1, postgres-sa1, sa1} on {linux-64, osx-arm64}
{bigquery-sa1, db2-sa1, impala-sa1, mssql-sa1, postgres-sa1, sa1} on {linux-64, osx-arm64}
Footnotes
Bold means explicit dependency. ↩ ↩2
Dependency got downgraded. ↩