Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address mssql CI failure #255

Merged
merged 5 commits into from
Dec 26, 2024
Merged

Address mssql CI failure #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ea58427
Attempt to work with image's driver.
kklein Dec 23, 2024
4c50fa9
Change name of driver.
kklein Dec 23, 2024
b7ea9ad
Test freetds driver.
kklein Dec 23, 2024
a3bd889
Remove manual installation of driver.
kklein Dec 23, 2024
db627d9
Undo change.
kklein Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,6 @@ jobs:
uses: prefix-dev/setup-pixi@v0.8.1
with:
environments: ${{ matrix.env }}
# TODO: Consider removing this manual installation since the docker image already comes with a msodbc driver.
- name: Install msodbcsql17 driver
run: |
wget https://packages.microsoft.com/ubuntu/20.04/prod/pool/main/m/msodbcsql17/msodbcsql17_17.9.1.1-1_amd64.deb
ACCEPT_EULA=Y sudo apt install ./msodbcsql17_17.9.1.1-1_amd64.deb --allow-downgrades
- name: Wait for SQL Server
timeout-minutes: 1
run: until docker logs "${{ job.services.db.id }}" 2>&1 | grep -q "SQL Server is now ready"; do sleep 10; done
Expand Down
2 changes: 1 addition & 1 deletion pixi.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ freetds = "*"
[feature.mssql.tasks]
test = "pytest tests/integration --backend=mssql"
test_freetds = "pytest tests/integration --backend=mssql-freetds"
coverage = "pytest tests/integration --cov=datajudge --cov-report=xml --cov-append --backend=mssql"
coverage = "pytest tests/integration --cov=datajudge --cov-report=xml --cov-append --backend=mssql-freetds"

[feature.postgres.dependencies]
psycopg2 = "*"
Expand Down
Loading