Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use modern linters #237

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Use modern linters #237

merged 3 commits into from
Jul 5, 2024

Conversation

pavelzw
Copy link
Member

@pavelzw pavelzw commented Jul 3, 2024

No description provided.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 38.48%. Comparing base (3b17133) to head (4ce1006).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/datajudge/constraints/uniques.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3b17133) and HEAD (4ce1006). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (3b17133) HEAD (4ce1006)
50 21
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #237       +/-   ##
===========================================
- Coverage   93.35%   38.48%   -54.87%     
===========================================
  Files          18       18               
  Lines        1985     1985               
===========================================
- Hits         1853      764     -1089     
- Misses        132     1221     +1089     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavelzw
Copy link
Member Author

pavelzw commented Jul 3, 2024

HEAD has 28 uploads less than BASE

still seems a bit off 🤔

@kklein
Copy link
Collaborator

kklein commented Jul 3, 2024

I'm not sure whether this is related but this PR #236 was not a squash merge and changed history from before its first commit.

Copy link
Collaborator

@kklein kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@pavelzw pavelzw merged commit 0f3e9cb into main Jul 5, 2024
32 of 34 checks passed
@pavelzw pavelzw deleted the modern-linters branch July 5, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants