Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disable cache #234

Merged
merged 65 commits into from
Jul 1, 2024
Merged

Allow disable cache #234

merged 65 commits into from
Jul 1, 2024

Conversation

SimonLangerQC
Copy link
Contributor

@SimonLangerQC SimonLangerQC commented Jun 28, 2024

This PR adds a lru_cache_maxsize parameter to each constraint
--> user can control caching behavior and disable it in memory-constrained cases

MariusMerkleQC and others added 30 commits April 3, 2024 16:54
Co-authored-by: quant-ranger[bot] <132915763+quant-ranger[bot]@users.noreply.github.com>
Bumps [google-github-actions/auth](https://github.com/google-github-actions/auth) from 2.1.2 to 2.1.3.
- [Release notes](https://github.com/google-github-actions/auth/releases)
- [Changelog](https://github.com/google-github-actions/auth/blob/main/CHANGELOG.md)
- [Commits](google-github-actions/auth@55bd3a7...71fee32)

---
updated-dependencies:
- dependency-name: google-github-actions/auth
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [mamba-org/setup-micromamba](https://github.com/mamba-org/setup-micromamba) from 1.8.1 to 1.9.0.
- [Release notes](https://github.com/mamba-org/setup-micromamba/releases)
- [Commits](mamba-org/setup-micromamba@4225001...f8b8a1e)

---
updated-dependencies:
- dependency-name: mamba-org/setup-micromamba
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…y scripts for postgres integration testing from a fresh db every time
Co-authored-by: Ignacio Vergara Kausel <ivergarakausel@gmail.com>
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
@SimonLangerQC SimonLangerQC marked this pull request as ready for review June 28, 2024 07:25
@SimonLangerQC SimonLangerQC requested review from kklein and 0xbe7a June 28, 2024 07:26
Copy link
Collaborator

@ivergara ivergara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it seems that this PR does more than allowing disabling the cache?

@SimonLangerQC
Copy link
Contributor Author

SimonLangerQC commented Jun 28, 2024

Why it seems that this PR does more than allowing disabling the cache?

There were considerable changes to the repo in between me creating the branch and now making the PR --> I had to resolve many merge conflicts. Looking into the files diff shows that I only add the new parameter (this happens in many locations: for each inheriting constraint, and for the add_... methods; I further add appropriate testing

@SimonLangerQC SimonLangerQC requested a review from ivergara June 28, 2024 08:04
SimonLangerQC and others added 2 commits June 28, 2024 14:59
Co-authored-by: Bela Stoyan <bela.stoyan@quantco.com>
Co-authored-by: Bela Stoyan <bela.stoyan@quantco.com>
Co-authored-by: Bela Stoyan <bela.stoyan@quantco.com>
SimonLangerQC and others added 2 commits June 28, 2024 16:47
@SimonLangerQC SimonLangerQC merged commit 676a4d5 into main Jul 1, 2024
33 checks passed
@SimonLangerQC SimonLangerQC deleted the allow-disable-cache branch July 1, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants