Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit dates example. #220

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Edit dates example. #220

merged 1 commit into from
Apr 3, 2024

Conversation

kklein
Copy link
Collaborator

@kklein kklein commented Apr 3, 2024

Before:

Screenshot 2024-04-03 at 17 03 10

After:

Screenshot 2024-04-03 at 17 03 14

@kklein kklein requested a review from ivergara April 3, 2024 15:04
@kklein kklein added the ready label Apr 3, 2024
@kklein
Copy link
Collaborator Author

kklein commented Apr 3, 2024

Thanks for bringing this to my attention @MariusMerkleQC :)

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.71%. Comparing base (cb8e025) to head (211773d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
- Coverage   93.76%   93.71%   -0.06%     
==========================================
  Files          18       18              
  Lines        1894     1894              
==========================================
- Hits         1776     1775       -1     
- Misses        118      119       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MariusMerkleQC
Copy link
Contributor

Oh, thanks for fixing this as well! I saw the weird formatting as well, but didn't know how to fix it!

@kklein kklein merged commit 246bb47 into main Apr 3, 2024
56 of 57 checks passed
@kklein kklein deleted the date_example_editing branch April 3, 2024 16:45
kklein added a commit that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants