Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests #26

Merged
merged 20 commits into from
Feb 12, 2025
Merged

Integration tests #26

merged 20 commits into from
Feb 12, 2025

Conversation

PaulKMueller
Copy link
Collaborator

Motivation

Before this PR, a lot of integration tests are not that stringent.
Also, we found that in many scenarios, it can be useful to list environments that should be excluded instead of listing all the environments that should be included in conda-deny license checks.

Changes

This PR makes the integration tests more stringent and adds the CLI flag and config option of exclude-environment which allows for the above described use case.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.58%. Comparing base (9e4f0c3) to head (369dc29).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   84.25%   88.58%   +4.33%     
==========================================
  Files          12       12              
  Lines         508      508              
==========================================
+ Hits          428      450      +22     
+ Misses         80       58      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaulKMueller PaulKMueller marked this pull request as ready for review February 11, 2025 19:31
@PaulKMueller PaulKMueller enabled auto-merge (squash) February 12, 2025 10:47
Copy link
Member

@pavelzw pavelzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

image
very nice 👌🏻

@pavelzw pavelzw merged commit b19d2ab into main Feb 12, 2025
16 checks passed
@pavelzw pavelzw deleted the exclude-env branch February 12, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants