Fix exception issue and add regression tests #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelzw
reviewed
Nov 16, 2024
| poppler = ">=24.8.0,<25" | ||
|
|
||
| [tool.conda-deny] | ||
| license-whitelist = "/Users/pkm/Projects/conda-deny/tests/test_end_to_end/test_exception_use_case/whitelist_with_exception.toml" |
There was a problem hiding this comment.
This shouldn't be absolute. Why did it pass CI?
There was a problem hiding this comment.
Because just failure of the command execution is asserted for the integration test.
The unit tests should ensure the bug is fixed, but the integration test becomes useless.
I'll open a new PR with more stringent tests (for the other integration tests as well) that implements cleaner writing to stdout and stderr. That should also improve the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Before this PR, issues could result from having, e.g.,
GPL-2.0-only WITH GCC-exception-2.0whitelisted and checking a package withGPL-2.0-only.conda-denywould not let the latter pass without checking for the exception in the whitelist.Thanks @SimonLangerQC for pointing this out.
Changes
This PR adapts the checking to be more restrictive and adds a couple of regression tests.