add docs on running pytest under TSAN #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
reviewed
Feb 17, 2025
There was a problem hiding this comment.
This all looks good and is quite useful, thanks @ngoldbaum. One suggestion for further content: can you say something more about halt_on_error=1? For me it was surprising that that didn't just exist the pytest run after the first failure, but actually hung the process without the option to even kill it with Ctrl-C or Ctrl-Z, only to force-quit in Activity Monitor on macOS - with CPUs being used at >=100%. I'm not sure how common it is, but it's consistent on my machine.
|
I’ve never seen that behavior but I’ll add a warning about hangs seen by some authors. |
rgommers
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.