Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): fix punycode deprecation warning #9340

Merged
merged 4 commits into from
Feb 27, 2025
Merged

Conversation

Slowlife01
Copy link
Contributor

@Slowlife01 Slowlife01 commented Feb 26, 2025

node-fetch uses older version of whatwg-url

no more warning
image

image

@Bas950 Bas950 added dependencies Pull requests that update a dependency file repo maintenance General repo maintenance, including updating tools etc labels Feb 26, 2025
@Timeraa
Copy link
Member

Timeraa commented Feb 27, 2025

What's using node-fetch even? We shouldn't be needing it since fetch is built in now?

@Slowlife01
Copy link
Contributor Author

What's using node-fetch even? We shouldn't be needing it since fetch is built in now?

Seems like discord-rpc

@Bas950 Bas950 enabled auto-merge (squash) February 27, 2025 09:34
@Bas950 Bas950 requested a review from theusaf February 27, 2025 09:34
@Bas950 Bas950 merged commit 6742759 into PreMiD:main Feb 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file repo maintenance General repo maintenance, including updating tools etc
Development

Successfully merging this pull request may close these issues.

4 participants