feat(General.json): add more strings and make strings consistent across activities #9291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss general.json & activities feat: test feat: test chore(General.json): sort file
darkvillager2
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
theusaf
added
activity update
multiple activities
theusaf
approved these changes
Feb 17, 2025
Bas950
reviewed
Feb 18, 2025
darkvillager2
commented
Feb 22, 2025
Signed-off-by: github plz bring back DarkVIllager <darkville14@gmail.com>
auto-merge was automatically disabled
February 22, 2025 10:48
Head branch was pushed to by a user without write access
Bas950
approved these changes
Feb 23, 2025
|
@darkvillager2 merge conflicts xD |
Signed-off-by: github plz bring back DarkVIllager <darkville14@gmail.com>
websites/E/Eurogamer/metadata.json
Outdated
| @@ -25,7 +25,7 @@ | |||
| "www.eurogamer.nl", | |||
| "www.eurogamer.pl" | |||
| ], | |||
| "version": "1.0.3", | |||
| "version": "1.0.5", | |||
Check failure
Code scanning / PMD
Makes sure the version is bumped Error
PreMiD-Automations
force-pushed
the
main
branch
2 times, most recently
from
838facc to
ee88c98
Compare
darkvillager2
commented
Feb 25, 2025
Signed-off-by: github plz bring back DarkVIllager <darkville14@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds strings from #9233 as general strings, also adds the strings for #9248
Acknowledgements
yarn formatScreenshots
Proof showing the creation/modification is working as expected
n/a