-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Teckie): add Teckie support #9280
base: main
Are you sure you want to change the base?
Conversation
now a 560x560
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For English see below.
---------
Hallo Maatje,
Bedankt voor je PR. Ik heb wat opmerkingen/vragen hierover. Graag de verzochte wijzigingen maken.
Mocht je vragen hebben, stel ze in dit PR of op discord (@dark_ville)
Groet,
Mede Kaaskop
Dark
-----------
Hello Mate,
Thanks for your PR, i have some questions/notes about it. Please make the changes as requested.
If you have any questions feel free to ask in this pr or on discord (@dark_ville)
~Dark
Hello from mobile, I've been and still am sick with the flu. Will make changes once I'm better. |
Co-authored-by: github plz bring back DarkVIllager <darkville14@gmail.com> Signed-off-by: bakzkndd <50497725+bakzkndd@users.noreply.github.com>
Co-authored-by: github plz bring back DarkVIllager <darkville14@gmail.com> Signed-off-by: bakzkndd <50497725+bakzkndd@users.noreply.github.com>
Co-authored-by: github plz bring back DarkVIllager <darkville14@gmail.com> Signed-off-by: bakzkndd <50497725+bakzkndd@users.noreply.github.com>
Co-authored-by: github plz bring back DarkVIllager <darkville14@gmail.com> Signed-off-by: bakzkndd <50497725+bakzkndd@users.noreply.github.com>
realized that all the cases could get their info from the same place, so to reduce double code just moved it to the bottom
oh no I forgot the good commit names |
c66558f
to
0ba4477
Compare
838facc
to
ee88c98
Compare
Co-authored-by: Bas van Zanten <bas.van.zanten007@gmail.com> Signed-off-by: bakzkndd <50497725+bakzkndd@users.noreply.github.com>
Co-authored-by: Bas van Zanten <bas.van.zanten007@gmail.com> Signed-off-by: bakzkndd <50497725+bakzkndd@users.noreply.github.com>
Co-authored-by: Bas van Zanten <bas.van.zanten007@gmail.com> Signed-off-by: bakzkndd <50497725+bakzkndd@users.noreply.github.com>
Co-authored-by: Daniel Lau <32113157+theusaf@users.noreply.github.com> Signed-off-by: bakzkndd <50497725+bakzkndd@users.noreply.github.com>
}, | ||
"url": "teckie.nl", | ||
"version": "1.0.0", | ||
"logo": "https://i.imgur.com/KKFlQ9m.png", |
Check failure
Code scanning / PMD
Makes sure all images (logo and URLs) are exactly 512x512 pixels Error
}) | ||
|
||
enum ActivityAssets { | ||
Logo = 'https://i.imgur.com/KKFlQ9m.png', |
Check failure
Code scanning / PMD
Makes sure all images (logo and URLs) are exactly 512x512 pixels Error
Description
Add support for Teckie. A dutch computer sales, repair and support company. Has support for all pages. Checkout page just shows the status for the base url to protect privacy.
Sidenote: didn't run
yarn format
but insteadnpm run lint:fix
.yarn format
didn't work for me and was told in the Discord server to usenpm run lint:fix
instead. Not sure if the PR template needs updating.Acknowledgements
yarn format
Screenshots
Proof showing the creation/modification is working as expected
Example 1:


Example 2:


