feat(nadeshiko): add activity #9206
Conversation
|
I don't know why it changed all the other Activities metadata files, is it normal? |
websites/N/nadeshiko/metadata.json
Outdated
| }, | ||
| "url": "nadeshiko.io", | ||
| "version": "1.0.0", | ||
| "logo": "https://i.imgur.com/3QzrCo4.png", |
There was a problem hiding this comment.
logo must be 512x512
There was a problem hiding this comment.
It should be a square as well
There was a problem hiding this comment.
That one should be good. Please apply the URL to the code and commit it.
websites/N/nadeshiko/presence.ts
Outdated
| browsingTimestamp = Math.floor(Date.now() / 1000); | ||
|
|
||
| const enum Assets { | ||
| Logo = "https://i.imgur.com/3QzrCo4.png", |
There was a problem hiding this comment.
| Logo = "https://i.imgur.com/3QzrCo4.png", | |
| Logo = "https://i.imgur.com/tDAXNRP.png", |
There was a problem hiding this comment.
Isn't there a way to get the Logo URL from the metadata logo field?
There was a problem hiding this comment.
I suppose you could import the metadata json, but it's probably fine/better to update the url in the code instead
websites/N/nadeshiko/presence.ts
Outdated
| if (oldLang !== languageSetting) { | ||
| oldLang = languageSetting; | ||
|
|
||
| strings = await getStrings(); | ||
| } |
There was a problem hiding this comment.
The current implementation of getStrings no longer needs the oldLang hack to work efficiently. Instead, just embed the presence.getStrings directly here
const strings = await presence.getStrings(...)
websites/K/kisskh/metadata.json
Outdated
There was a problem hiding this comment.
Revert this change. (You might need to update your branch)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
I have to update something for the /leaderboards page btw, I'll try to update it ASAP. |
| function homePage() { | ||
| presenceData.details = strings.viewHome; | ||
| presenceData.state = `${strings.search} for a player or guild...`; | ||
| presenceData.smallImageKey = Assets.Search; |
Check failure
Code scanning / PMD
Makes sure the TypeScript files are correct Error
| gameSelected && leaderboardSelected | ||
| ? `${ | ||
| strings.viewing | ||
| } ${gameSelected?.textContent.trim()} - ${leaderboardSelected?.textContent.trim()} leaderboard` |
Check failure
Code scanning / PMD
Makes sure the TypeScript files are correct Error
| gameSelected && leaderboardSelected | ||
| ? `${ | ||
| strings.viewing | ||
| } ${gameSelected?.textContent.trim()} - ${leaderboardSelected?.textContent.trim()} leaderboard` |
Check failure
Code scanning / PMD
Makes sure the TypeScript files are correct Error
| } ${gameSelected?.textContent.trim()} - ${leaderboardSelected?.textContent.trim()} leaderboard` | ||
| : `${strings.search} for a leaderboard...`; | ||
| presenceData.smallImageKey = | ||
| gameSelected && leaderboardSelected ? Assets.Viewing : Assets.Search; |
Check failure
Code scanning / PMD
Makes sure the TypeScript files are correct Error
| } ${gameSelected?.textContent.trim()} - ${leaderboardSelected?.textContent.trim()} leaderboard` | ||
| : `${strings.search} for a leaderboard...`; | ||
| presenceData.smallImageKey = | ||
| gameSelected && leaderboardSelected ? Assets.Viewing : Assets.Search; |
Check failure
Code scanning / PMD
Makes sure the TypeScript files are correct Error
| else { | ||
| presenceData.details = `${strings.viewProfile} ${playerOrGuild}`; | ||
| presenceData.state = `${strings.viewing} guild stats`; | ||
| presenceData.smallImageKey = Assets.Viewing; |
Check failure
Code scanning / PMD
Makes sure the TypeScript files are correct Error
| return homePage(); | ||
| else { | ||
| presenceData.details = `${strings.viewProfile} ${playerOrGuild}`; | ||
| presenceData.state = `${strings.viewing} ${achievementsGameNames[game]} achievements`; |
Check failure
Code scanning / PMD
Makes sure the TypeScript files are correct Error
| else { | ||
| presenceData.details = `${strings.viewProfile} ${playerOrGuild}`; | ||
| presenceData.state = `${strings.viewing} ${achievementsGameNames[game]} achievements`; | ||
| presenceData.smallImageKey = Assets.Viewing; |
Check failure
Code scanning / PMD
Makes sure the TypeScript files are correct Error
| else { | ||
| presenceData.details = `${strings.viewProfile} ${playerOrGuild}`; | ||
| presenceData.state = `${strings.viewing} quests`; | ||
| presenceData.smallImageKey = Assets.Viewing; |
Check failure
Code scanning / PMD
Makes sure the TypeScript files are correct Error
| return presence.setActivity({ | ||
| details: strings.browsing, | ||
| startTimestamp: browsingTimestamp, | ||
| smallImageKey: Assets.Viewing, |
Check failure
Code scanning / PMD
Makes sure the TypeScript files are correct Error
| "thumbnail": "https://i.imgur.com/9wL3Frb.png", | ||
| "color": "#872D4D", | ||
| "category": "games", | ||
| "tags": [ |
Check failure
Code scanning / PMD
Makes sure the `tags` don't contain the service name Error
PreMiD-Automations
force-pushed
the
main
branch
2 times, most recently
from
838facc to
ee88c98
Compare
theusaf
added
the
inactive
Acknowledgements
yarn formatScreenshots
Proof showing the creation/modification is working as expected