filter skins in favs that dont exist anymore

PrashantMohta · Jul 29, 2024 · d4e9e48 · d4e9e48
1 parent 9d0e0b1
commit d4e9e48
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/CustomKnight/NewUI/UIController.cs b/CustomKnight/NewUI/UIController.cs
@@ -218,7 +218,6 @@ public static void CreateUpdateGUI()
             var favSkins = new List<string>();
             favSkins.AddRange(CustomKnight.GlobalSettings.FavoriteSkins);
             favSkins.AddRange(CustomKnight.GlobalSettings.RecentSkins);
-            favSkins = favSkins.Distinct().ToList();
             for (var index = 0; favSkins.Count < Math.Min(CustomKnight.GlobalSettings.MaxSkinCache, SkinManager.SkinsList.Count); index++)
             {
                 var id = SkinManager.SkinsList[index].GetId();
@@ -229,6 +228,10 @@ public static void CreateUpdateGUI()
             }
             foreach (var skinId in favSkins)
             {
+                if (!SkinManager.SkinExistsById(skinId))
+                {
+                    continue;
+                }
                 var skin = SkinManager.GetSkinById(skinId);
                 var tex = GetSkinIcon(skin);
                 var skinName = skin.GetName();

diff --git a/CustomKnight/Skin/Base/SkinManager.cs b/CustomKnight/Skin/Base/SkinManager.cs
@@ -323,6 +323,16 @@ public static bool AddSkin(ISelectableSkin NewSkin)
             return !Exists;
         }
 
+        /// <summary>
+        ///    Checks if a skin from the overall skin list exists that matches a given id.
+        /// </summary>
+        /// <param name="id"></param>
+        /// <returns> true if exists </returns>
+        public static bool SkinExistsById(string id)
+        {
+            return SkinManager.SkinsList.Exists(skin => skin.GetId() == id);
+        }
+
         /// <summary>
         ///     Gets a skin from the overall skin list that matches a given id.
         /// </summary>