Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rclone #15204

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Feature/rclone #15204

wants to merge 5 commits into from

Conversation

milzi234
Copy link
Contributor

Short description

Uses rclone to copy documentation to the S3 bucket. Contrary to a previous PR, it uses rclone copy instead of rclone sync so as to never delete files in the bucket. Cache invalidation is run without waiting for it to complete to speed up the workflow.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13493597961

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 56 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+3.8%) to 64.489%

Files with Coverage Reduction New Missed Lines %
pdns/backends/gsql/gsqlbackend.hh 1 97.71%
pdns/misc.cc 2 62.46%
pdns/recursordist/lwres.cc 2 70.0%
pdns/recursordist/pdns_recursor.cc 2 72.42%
pdns/signingpipe.cc 2 83.38%
pdns/iputils.cc 3 56.99%
pdns/rcpgenerator.cc 3 90.28%
pdns/recursordist/test-syncres_cc2.cc 3 88.91%
modules/godbcbackend/sodbc.cc 4 70.8%
pdns/recursordist/rec-tcp.cc 4 64.73%
Totals Coverage Status
Change from base Build 13458196542: 3.8%
Covered Lines: 127621
Relevant Lines: 166889

💛 - Coveralls

@Habbie Habbie self-requested a review February 24, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants