Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use fail-fast: false for more jobs #15186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Feb 20, 2025

Short description

CI appears to be flaky because of random networking problems. It seems more useful to let the other jobs run and potentially pass than to just kill them when something flaky flakes.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@coveralls
Copy link

coveralls commented Feb 20, 2025

Pull Request Test Coverage Report for Build 13441220383

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 57 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+3.8%) to 64.501%

Files with Coverage Reduction New Missed Lines %
ext/json11/json11.cpp 2 62.72%
pdns/misc.cc 2 62.46%
pdns/recursordist/rec-tcpout.cc 3 61.9%
pdns/recursordist/syncres.cc 3 80.3%
pdns/recursordist/test-syncres_cc2.cc 3 88.85%
pdns/signingpipe.cc 5 83.11%
pdns/dnsdistdist/dnsdist-carbon.cc 6 61.7%
pdns/recursordist/test-syncres_cc1.cc 6 89.57%
pdns/dnsdistdist/dnsdist-tcp.cc 8 75.82%
pdns/recursordist/rec-system-resolve.cc 19 45.92%
Totals Coverage Status
Change from base Build 13433765276: 3.8%
Covered Lines: 127617
Relevant Lines: 166903

💛 - Coveralls

Copy link
Member

@romeroalx romeroalx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants