Merge pull request #6 from jklein24/master

A bunch of type fixes caught by the JSCompiler
PolymerElements · May 4, 2015 · 6b56de5 · 6b56de5
2 parents a094802 + df3570d
commit 6b56de5
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 14 deletions.
diff --git a/iron-multi-selectable.html b/iron-multi-selectable.html
@@ -65,7 +65,7 @@
        * `value` will be toggled; otherwise the `value` will be selected.
        *
        * @method select
-       * @param {String} value the value to select.
+       * @param {string} value the value to select.
        */
       select: function(value) {
         if (this.multi) {

diff --git a/iron-selectable.html b/iron-selectable.html
@@ -21,7 +21,7 @@
        * set this to the name of the attribute.
        *
        * @attribute attrForSelected
-       * @type String
+       * @type {string}
        */
       attrForSelected: {
         type: String,
@@ -32,7 +32,7 @@
        * Gets or sets the selected element. The default is to use the index of the item.
        *
        * @attribute selected
-       * @type String
+       * @type {string}
        */
       selected: {
         type: String,
@@ -43,7 +43,7 @@
        * Returns the currently selected item.
        *
        * @attribute selectedItem
-       * @type Object
+       * @type {Object}
        */
       selectedItem: {
         type: Object,
@@ -57,7 +57,7 @@
        * Set to empty string to listen to no events.
        *
        * @attribute activateEvent
-       * @type String
+       * @type {string}
        * @default 'click'
        */
       activateEvent: {
@@ -71,15 +71,15 @@
        * are selectable.
        *
        * @attribute selectable
-       * @type String
+       * @type {string}
        */
       selectable: String,
 
       /**
        * The class to set on elements when selected.
        *
        * @attribute selectedClass
-       * @type String
+       * @type {string}
        */
       selectedClass: {
         type: String,
@@ -90,7 +90,7 @@
        * The attribute to set on elements when selected.
        *
        * @attribute selectedAttribute
-       * @type String
+       * @type {string}
        */
       selectedAttribute: {
         type: String,
@@ -154,7 +154,7 @@
      * Selects the given value.
      *
      * @method select
-     * @param {String} value the value to select.
+     * @param {string} value the value to select.
      */
     select: function(value) {
       this.selected = value;

diff --git a/iron-selection.html b/iron-selection.html
@@ -12,6 +12,10 @@
 
 <script>
 
+  /**
+   * @param {!Function} selectCallback
+   * @constructor
+   */
   Polymer.IronSelection = function(selectCallback) {
     this.selection = [];
     this.selectCallback = selectCallback;
@@ -49,7 +53,7 @@
      * Indicates if a given item is selected.
      *
      * @method isSelected
-     * @param {any} item The item whose selection state should be checked.
+     * @param {*} item The item whose selection state should be checked.
      * @returns Returns true if `item` is selected.
      */
     isSelected: function(item) {
@@ -60,8 +64,8 @@
      * Sets the selection state for a given item to either selected or deselected.
      *
      * @method setItemSelected
-     * @param {any} item The item to select.
-     * @param {Boolean} isSelected True for selected, false for deselected.
+     * @param {*} item The item to select.
+     * @param {boolean} isSelected True for selected, false for deselected.
      */
     setItemSelected: function(item, isSelected) {
       if (item != null) {
@@ -85,7 +89,7 @@
      * the `item` will be selected.
      *
      * @method select
-     * @param {any} item The item to select.
+     * @param {*} item The item to select.
      */
     select: function(item) {
       if (this.multi) {
@@ -100,7 +104,7 @@
      * Toggles the selection state for `item`.
      *
      * @method toggle
-     * @param {any} item The item to toggle.
+     * @param {*} item The item to toggle.
      */
     toggle: function(item) {
       this.setItemSelected(item, !this.isSelected(item));