Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property to opt out of focus() on _focusedItemChanged #97

Closed
wants to merge 1 commit into from
Closed

Conversation

jpodwys
Copy link

@jpodwys jpodwys commented Oct 27, 2017

This PR goes with #96.

@jpodwys
Copy link
Author

jpodwys commented Nov 17, 2017

@jpodwys
Copy link
Author

jpodwys commented Nov 27, 2017

Boy, what a roller coaster of anticipation this past month since I opened this PR has been. Not sure my tender heart can take any more. What say you we merge this little guy?

@bicknellr @notwaldorf @cdata @rictic

@jpodwys jpodwys changed the title Property to opt out of fucus() on _focusedItemChanged Property to opt out of focus() on _focusedItemChanged Nov 27, 2017
@bicknellr
Copy link
Contributor

I think this request might be better served by preventing this line from asking to focus the item. I don't think it really makes sense to disable the focusing behavior in the observer for focusedItem itself, since that's pretty much the only point of setting it. It seems reasonable not to want to focus when selecting an item though - maybe replacing that line with something like this._setFocusedItem(this.theNewPropertyName ? item : null) is closer to what you're looking for? Is calling select the only case that this is a problem?

@bicknellr
Copy link
Contributor

I just noticed that IronMultiSelectableBehavior and IronSelectableBehavior are inconsistent in how they handle fallbackSelection: the first uses select and the second sets selected. Maybe we should update IronMultiSelectableBehavior to set selected instead?

@jpodwys
Copy link
Author

jpodwys commented Nov 28, 2017

I'm currently selecting the first item with .select(0). I tried switching to .selected = 0 and that seems to help a lot. I still see glitches sometimes, but I'm not certain where they're coming from. Regardless, it's objectively better than what I currently have.

As for your proposed change to iron-multi-selectable, I'm still pinned to 1.x of the component which is significantly different, so I wasn't able to check if that fix would work for me.

@bicknellr
Copy link
Contributor

I still see glitches sometimes

Do you mean that it still occasionally focuses the items when you select them?

@jpodwys
Copy link
Author

jpodwys commented Nov 28, 2017

If by "when you select them," you mean when .selected = 0 runs, it appears that way, yes. But I haven't confirmed that's what's happening.

@jpodwys jpodwys closed this Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants