Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bookend entity sets with datatype and acquisition entities #442

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Bookend entity sets with datatype and acquisition entities #442

wants to merge 4 commits into from

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Feb 24, 2025 •
edited
Loading

Closes #441.

Changes proposed in this pull request

  • Put datatype at the beginning, and acquisition at the end, of entity sets.

@tsalo tsalo added the enhancement New feature or request label Feb 24, 2025
@tsalo tsalo requested review from tientong98 and singlesp February 24, 2025 19:22
singlesp
singlesp approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@singlesp singlesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@singlesp singlesp singlesp approved these changes

@tientong98 tientong98 Awaiting requested review from tientong98

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Place datatype at beginning, and acquisition at end, of entity strings
2 participants
@tsalo @singlesp