Different rms/bkg modes, adaptive box size, rejig #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For what it is worth, I think the default behavior is preserved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got a little carried away when looking at changing the way bane calculates the background and rms. I have added some other modes that can be specified on the CLI.
There is also the start of an adaptive box size mode. The idea being that different box car sizes (and potentially smoothed scales) could be used. At the moment the only consideration that is made is the number of pixels that survived the clipping. If too many pixels were clipped, use a larger box.
I have also rejigged the code a little to separate out the logic a little more clearly, and try to separate out the functions into smaller more isolated units of work.