-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New queue playback solution #13
Open
Zensonaton
wants to merge
11
commits into
Pato05:main
Choose a base branch
from
Zensonaton:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d3514bc
New implementation for shuffle indexies, code formatting.
Zensonaton 52a29fa
Fix null pointer error.
Zensonaton c836d09
Fix `load`.
Zensonaton 49d08f7
Fix initial `load` with enabled shuffle.
Zensonaton 23b07d5
Fix `concatenatingInsertAll`.
Zensonaton 45a1fe4
WIP implementation of `setShuffleOrder` method.
Zensonaton 6705617
Merge remote-tracking branch 'upstream/main'
Zensonaton ed10496
fix a few things:
Pato05 62fd4e7
Merge remote-tracking branch 'upstream/main'
Pato05 a2e6c8a
Improvements in documentation, variable names, method placing, format…
Zensonaton 529af19
Prefetch implementation.
Zensonaton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be done. It should be the user's choice whether to enable
just_audio_media_kit
to be used instead of the default plugin on macOS.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused about this one... I've cleaned my code, so brackets won't confuse you:
I haven't removed the
isMacOS
check, it is still present in my code. Or am I missing something here?Basically, my code does the exact same thing as your did, but instead of this:
I've changed it to this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I'm sorry, I didn't read it properly.
Though readability-wise, I liked it more my way, it's more straightforward since it's just one "if" statement, and a pretty long one, too.