Add support for Kingmaker ally rarity mod #8556
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
EDIT: Needs work. Reasons below.
If this is still true, then a few things need to be fixed. Necromantic Aegis currently applies INC rarity to the minion from a shield, like Wheel of the Stormsail.
Animated Guardian also should not gain rarity from his gear. PoB currently let's AG gain rarity.
Still unsure if Kingmaker Aura should give minions rarity or not. Can't find an answer about auras giving rarity.
Kingmaker give allies 30% inc rarity. Implemented now
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/X7roDK_p0zJD
After screenshot: