Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Soul Core stat requirement conversion #835

Merged
merged 4 commits into from
Mar 11, 2025

Conversation

haugenc
Copy link
Contributor

@haugenc haugenc commented Mar 5, 2025

Fixes #153 .

Description of the problem being solved:

Rune: Soul Core of Cholotl
Rune: Soul Core of Zantipi
Rune: Soul Core of Atmohua
do not properly redistribute stats on gear.

Created mod in special mod list and updated logic in Classes/Item.lua to process flag and apply convert calcuations to base.

Steps taken to verify a working solution:

-Added custom item on Expert Barrier Quarterstaff base with all three runes and matched values to in-game calculation
-Added custom item on Expert Tribal Mask base with one rune + reduced Attribute Requirements and matched values to in-game calcs
-Matched Attribute Requirement calculations to items equipped
-Test case added to TestItemParse_spec.lua

Link to a build that showcases this PR:

https://maxroll.gg/poe2/pob/lt5vh0et

Before screenshot:

Screenshot 2025-03-05 101344
Screenshot 2025-03-05 103528
Screenshot 2025-03-05 104137

After screenshot:

Screenshot 2025-03-05 101455
Screenshot 2025-03-05 103620
Screenshot 2025-03-05 104231

In-game Calcuations for items
Screenshot 2025-02-21 105930

@haugenc
Copy link
Contributor Author

haugenc commented Mar 5, 2025

Just a note about the development of this. I initially tried parsing by standard mod text, but couldn't get it to apply to base properly so the attr reqs scaled correctly to in-game values. Also tried adding a mods with flags of PercentStat of the relevant attr reqs, but calcLocal didn't seem to parse any mod in baseList where [1] exists.

@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Mar 10, 2025
@LocalIdentity LocalIdentity changed the title Resolves #153 - Update to Attribute Conversion Soul Core behavior. Add support for Soul Core stat requirement conversion Mar 10, 2025
@LocalIdentity LocalIdentity marked this pull request as ready for review March 11, 2025 04:23
@LocalIdentity LocalIdentity merged commit 2d120f0 into PathOfBuildingCommunity:dev Mar 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for base attribute requirement conversion
2 participants