Add support for Soul Core stat requirement conversion #835
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #153 .
Description of the problem being solved:
Rune: Soul Core of Cholotl
Rune: Soul Core of Zantipi
Rune: Soul Core of Atmohua
do not properly redistribute stats on gear.
Created mod in special mod list and updated logic in Classes/Item.lua to process flag and apply convert calcuations to base.
Steps taken to verify a working solution:
-Added custom item on Expert Barrier Quarterstaff base with all three runes and matched values to in-game calculation
-Added custom item on Expert Tribal Mask base with one rune + reduced Attribute Requirements and matched values to in-game calcs
-Matched Attribute Requirement calculations to items equipped
-Test case added to TestItemParse_spec.lua
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/lt5vh0et
Before screenshot:
After screenshot:
In-game Calcuations for items
