Add support for Bones of Ullr mod and fix Lord of Horrors #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #772 .
Description of the problem being solved:
Lord of Horrors tree node was parsing incorrectly. It was applying the reduced reservation as a stat to the minion itself I guess? Now it correctly applies reduced reservation to minion skill gems. We still don't increase the reservation according to the number of summoned minions yet using the count box in the skills tab though.
Bones of Ullr apply a 20% reduced reservation to undead minions. Maybe we could parse just "undead minions" as the
SkillType.CreatesUndeadMinion, but that doesn't line up with how "minions" is parsed everywhere else, so I chose to just check for the whole text.Steps taken to verify a working solution:
-Bones of Ullr doesn't apply to SRS in game, which aligns with the PoB2 logic.
-Lords of Horror does apply to SRS in game, which also aligns with PoB2 logic.
-Even though the SRS minion itself has the undead tag in poe2db, I guess they don't count? Not sure why, but PoB2 matches game logic and that's what matters.
-Works properly with the recent PR to count multiple minions. #761
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/sp6un058
Before screenshot:
After screenshot:
SRS
Skeletal Frost Mage
Ullr equipped and node taken with SRS and Skeletal Brute