Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Paranets #245

Merged
merged 66 commits into from
Jun 13, 2024
Merged

[FEATURE] Paranets #245

merged 66 commits into from
Jun 13, 2024

Conversation

br41nl3t
Copy link
Contributor

@br41nl3t br41nl3t commented Apr 4, 2024

No description provided.

@br41nl3t br41nl3t added feature New feature v6 Issue or development for OT-node version 6 release New release labels Apr 4, 2024
@br41nl3t br41nl3t self-assigned this Apr 4, 2024
@botnumberseven
Copy link

@u-hubar

It appears addStake function will be removed from Staking and StakingV2 ABIs. Not sure what would be used as a replacement for regular staking process. Anyway, that change will make these ABIs incompatible with current chain data, as addStake is used at the moment. Would be nice to keep it there.

When AccumulatedOperatorFeeRestaked is emitted in Profile, i assume regular staking events like stake_increased and shares_minted are also emitted. Correct?

Would it be possible to make AccumulatedOperatorFeeWithdrawalStarted event in Profile similar to StakeWithdrawalStarted and show old_accumulated_operator_fee and new_accumulated_operator_fee. It's a bit easier to track it that way, than only using amount value.

@br41nl3t
Copy link
Contributor Author

@botnumberseven

The function I changed the name for was never used for manual staking, there is a separate function with the same name for that. Anyways, I will revert back the name change just to keep things less complicated.

Correct.

New will always be 0 as there is no choice of how much to withdraw/restake, it always takes full amount. I can add possibility to choose amount if needed, just didn't really see the reason for why it would be useful

@botnumberseven
Copy link

@u-hubar
Oh, I missed we have two functions with the same addStake name. False alarm then.

Restake/withdraw amount.
If there is no delay for op fee withdrawal/restaking, then i agree, there is no value to allow custom amount here.

If there is a delay, custom amount might make sense:

  1. User wants to withdraw a portion of funds and restake a portion of funds. Without custom amount they would need to withdraw first, wait 28 days, then stake.
  2. User wants to restake, but their node of choice does not have enough room to accept all of his stake. Again they would have to withdraw, wait 28 days, then stake.
  3. User wants to split his accumulated op fee for 2+ nodes. They would need to withdraw, wait 28 days, then stake.

br41nl3t and others added 3 commits May 11, 2024 21:33
@br41nl3t br41nl3t requested a review from NZT48 May 31, 2024 12:43
br41nl3t and others added 26 commits May 31, 2024 15:28
Changed the way votersRegistrar is initialized in the ParanetIncentivesPool
… added unstake of inactive tokens without delay, removed redundant operator
…updated ParanetNeuroIncentivesPool not to rely on the receive function and included additional getters
…esPool + limits for specific role rewards, removed redundant code duplication in the Paranet contract to decrease contract size
…tion-separation

[IMPROVEMENT] Paranet Improvements #2
…es-calculation

[IMPROVEMENT] Paranet improvements #3
@br41nl3t br41nl3t merged commit 7bd7fcb into main Jun 13, 2024
3 checks passed
@br41nl3t br41nl3t deleted the feature/paranets branch June 13, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature release New release v6 Issue or development for OT-node version 6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants